-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ping): honor ping interval in case of errors #4423
Conversation
I don't think we can make it a boolean. The behaviour we need to retain is that the first error is "free", i.e. doesn't cause any problems. We want to be compatible with an implementation that uses one stream per ping. (Do we actually have a test for that?) I am open to changing the impl here but I'd prefer if that happens in a different PR and we focus this one on the fix for the stream spam. |
Co-authored-by: Thomas Eizinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but deferring to @thomaseizinger. Thank you for the work here.
Description
This PR adds a delay to ping connection handler after exceeding the failure rate to prevent opening a outbound stream right after an error.
Resolves #4410.
Notes & open questions
Would it be better to switchfailures
to a boolean instead?Change checklist