Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf): support iperf-style intermittent results #4382

Merged
merged 32 commits into from
Oct 25, 2023
Merged

feat(perf): support iperf-style intermittent results #4382

merged 32 commits into from
Oct 25, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Aug 23, 2023

Description

Notes & open questions

Required for libp2p/test-plans#261.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden mxinden mentioned this pull request Aug 24, 2023
Closed
@mxinden mxinden mentioned this pull request Sep 20, 2023
Merged
@thomaseizinger thomaseizinger mentioned this pull request Oct 16, 2023
Merged
4 tasks
@mxinden mxinden marked this pull request as ready for review October 19, 2023 11:39
@mxinden
Copy link
Member Author

mxinden commented Oct 19, 2023

@thomaseizinger can you give this pull request a review?

Note that libp2p-perf is not part of libp2p and that libp2p-perf is only used in https://github.com/libp2p/test-plans/blob/master/perf/. Thus we can iterate on it without worrying about breaking changes.

thomaseizinger
thomaseizinger reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts :)

protocols/perf/src/bin/perf.rs Outdated Show resolved Hide resolved
protocols/perf/src/bin/perf.rs Outdated Show resolved Hide resolved
protocols/perf/src/bin/perf.rs Outdated Show resolved Hide resolved
protocols/perf/src/bin/perf.rs Show resolved Hide resolved
protocols/perf/src/bin/perf.rs Show resolved Hide resolved
protocols/perf/src/protocol.rs Outdated Show resolved Hide resolved
protocols/perf/src/protocol.rs Show resolved Hide resolved
protocols/perf/src/server/handler.rs Outdated Show resolved Hide resolved
protocols/perf/src/server/handler.rs Outdated Show resolved Hide resolved
protocols/perf/src/server/handler.rs Outdated Show resolved Hide resolved
@mxinden
Copy link
Member Author

mxinden commented Oct 23, 2023

Thank you @thomaseizinger for your review! Mind taking another look?

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏

@mergify mergify bot merged commit d15bb69 into libp2p:master Oct 25, 2023
71 checks passed
mxinden added a commit to libp2p/test-plans that referenced this pull request Oct 25, 2023
@mxinden
Update to latest master
2e86c0f 
Now that libp2p/rust-libp2p#4382 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @thomaseizinger