Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relay): remove unconditional async-std dependency #4283

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

quininer
Copy link
Contributor

@quininer quininer commented Aug 2, 2023

Description

libp2p-relay crate specifies the libp2p-swarm/async-std feature, which causes an async-std dependency to always be introduced.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Sorry, something went wrong.

@quininer quininer changed the title Fix: relay specifies an unexpected dependency fix: relay specifies an unexpected dependency Aug 2, 2023
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice catch.

Can you patch-bump libp2p-relay please? Otherwise we can't release it. Plus a short changelog entry would be good.

You will also have to commit the log-file change and bump the relay version in the main mainfest (CI will tell you if you mess it up 😄 )

@thomaseizinger thomaseizinger changed the title fix: relay specifies an unexpected dependency fix(relay): remove unconditional async-std dependency Aug 2, 2023
@quininer
Copy link
Contributor Author

quininer commented Aug 2, 2023

@thomaseizinger I updated CHANGELOG, and I noticed that 0.16.1 has not been released yet, so I didn't update the patch version.

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 37d57f4 into libp2p:master Aug 2, 2023
@quininer quininer deleted the patch-2 branch August 2, 2023 14:03
hanabi1224 pushed a commit to hanabi1224/rust-libp2p that referenced this pull request Aug 3, 2023
`libp2p-relay` crate specifies the `libp2p-swarm/async-std` feature, which causes an `async-std` dependency to always be introduced.

Pull-Request: libp2p#4283.
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thank you for the fix!

thomaseizinger pushed a commit that referenced this pull request Aug 20, 2023
`libp2p-relay` crate specifies the `libp2p-swarm/async-std` feature, which causes an `async-std` dependency to always be introduced.

Pull-Request: #4283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants