-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(relay): remove unconditional async-std
dependency
#4283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Nice catch.
Can you patch-bump libp2p-relay
please? Otherwise we can't release it. Plus a short changelog entry would be good.
You will also have to commit the log-file change and bump the relay version in the main mainfest (CI will tell you if you mess it up 😄 )
async-std
dependency
@thomaseizinger I updated CHANGELOG, and I noticed that 0.16.1 has not been released yet, so I didn't update the patch version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
`libp2p-relay` crate specifies the `libp2p-swarm/async-std` feature, which causes an `async-std` dependency to always be introduced. Pull-Request: libp2p#4283.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 thank you for the fix!
`libp2p-relay` crate specifies the `libp2p-swarm/async-std` feature, which causes an `async-std` dependency to always be introduced. Pull-Request: #4283.
Description
libp2p-relay
crate specifies thelibp2p-swarm/async-std
feature, which causes anasync-std
dependency to always be introduced.Notes & open questions
Change checklist