-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gossipsub): add getter function to obtain TopicScoreParams
#4231
feat(gossipsub): add getter function to obtain TopicScoreParams
#4231
Conversation
The error on https://github.com/libp2p/rust-libp2p/actions/runs/5629137542/job/15253767856?pr=4231
|
@divagant-martian Thank you for your review! |
TopicScoreParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think exposing this makes sense. I left some minor comments :)
Co-authored-by: Thomas Eizinger <[email protected]>
error[E0507]: cannot move out of `self.peer_score` which is behind a shared reference
@thomaseizinger Thank you for your review! I've updated this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@mergify refresh |
✅ Pull request refreshed |
@mergify refresh |
✅ Pull request refreshed |
Multiple conversations were unresolved and thus mergify did not merge. In addition, mergify does not have permissions to update your pull request @ackintosh. For future pull requests, mind giving mergify permissions on your fork? |
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
Added a getter function to obtain `TopicScoreParams`. I need this function for testing which checks if scoring parameters are updated as expected. Pull-Request: #4231.
Description
Added a getter function to obtain
TopicScoreParams
. I need this function for testing which checks if scoring parameters are updated as expected.Notes & open questions
Change checklist