Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(identify): push changed listen protocols to remote #3980

Merged
merged 4 commits into from
May 25, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Now that we have the infrastructure for notifying protocols about changes to our listen protocols, we can use this to actively push those changes to our remotes. This allows other peers to re-configure themselves with very low-latency instead of waiting for the periodic identify event.

Resolves: #3613.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger requested a review from mxinden May 23, 2023 13:18
@thomaseizinger thomaseizinger added this to the v0.52.0 milestone May 23, 2023
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean. Thanks. Great to see all these pieces coming together.

@mergify mergify bot merged commit 137443b into master May 25, 2023
@mergify mergify bot deleted the feat/push-protocols-changes-identify branch May 25, 2023 01:09
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
Starting in #3980, we make more use of the identify push protocol by actively notifying the peer when our locally supported protocols change. We emit an event (`Pushed`) to the user in that case. This event however does not include **what** we pushed.

Users might be interested in the internal changes that we push to remote peers. This patch adds the identify `Info` to the `Pushed` variant.

Fixes #4332.

Pull-Request: #4527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

identify: Push changes in listen protocols via identify push
2 participants