Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): ensure all examples compile with the specified feature-set #3811

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Apr 20, 2023

Description

Due to cargo's feature unification, a full build of our workspace doesn't actually check whether the examples compile as standalone projects.

We add a new CI check that iterates through all crates in the examples/ directory and runs a plain cargo check on them. Any failure is bubbled up via set -e, thus failing CI in case one of the cargo check commands fails.

To fix the current failures, we construct a simple TCP transport everywhere where we were previously using development_transport. That is because development_transport requires mplex which is now deprecated.

Related #3657.
Related #3809.

Open tasks

  • Open a GitHub mgmt repository PR to make this mandatory once it is merged.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify mergify bot merged commit 28da3d4 into master Apr 21, 2023
@mergify mergify bot deleted the fix/examples-ci branch April 21, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants