Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(identity): leverage Copy impl for ed25519 public key #3706

Merged
merged 1 commit into from
Mar 30, 2023
Merged

refactor(identity): leverage Copy impl for ed25519 public key #3706

merged 1 commit into from
Mar 30, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Mar 30, 2023 •
edited
Loading

Description

No need for function calls to to_bytes and from_bytes if the type is Copy.

Related: #3649.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
Copy link
Contributor Author

Merging because this is trivial and passing CI should be good enough.

@drHuangMHT
Copy link
Contributor

Should I deprecate those methods in #3681?

@mergify mergify bot merged commit 75f967f into master Mar 30, 2023
@mergify mergify bot deleted the refactor/copy-public-key-ed25519 branch March 30, 2023 11:07
@thomaseizinger
Copy link
Contributor Author

Should I deprecate those methods in #3681?

No, they are still useful by themselves.

@drHuangMHT
Copy link
Contributor

Should I deprecate those methods in #3681?

No, they are still useful by themselves.

Ah what a dummy I was thinking of deprecating those, maybe I was out of mind.

@mxinden mxinden mentioned this pull request Apr 5, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @drHuangMHT