Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track Cargo.lock in CI #3399

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat: track Cargo.lock in CI #3399

merged 2 commits into from
Jan 30, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jan 30, 2023 •
edited
Loading

Description

Resolves #2853.

Notes

This has been triggered by mcginty/snow#146 which is currently blocking our CI from passing on every PR.
The Cargo.lock is freshly generated. I only applied cargo update -p [email protected] --precise 4.0.0-pre.5 after to make the build pass.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger mentioned this pull request Jan 30, 2023
Merged
4 tasks
jxs
jxs approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also thanks for the work on mcginty/snow#147 Thomas!

@jxs jxs added the send-it label Jan 30, 2023
@mergify mergify bot merged commit 2d080dc into master Jan 30, 2023
@mergify mergify bot deleted the fix/track-cargo-lock branch January 30, 2023 11:59
@mxinden mxinden mentioned this pull request Mar 3, 2023
Closed
mxinden added a commit to mxinden/rust-libp2p that referenced this pull request Mar 7, 2023
@mxinden
feat: Use cargo --locked whenever possible
11c1c15 
> Since libp2p#3399 we are tracking the `Cargo.lock` file via
version control. Currently CI does not fail when the checked in `Cargo.lock` is not up-to-date.

libp2p#3547
@mxinden mxinden mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@mxinden mxinden Awaiting requested review from mxinden

@elenaf9 elenaf9 Awaiting requested review from elenaf9

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider tracking Cargo.lock in Git
2 participants
@thomaseizinger @jxs