Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: remove EitherUpgrade #3339

Merged
merged 20 commits into from
Jan 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3a84c14
Use single quotes to avoid running commands
thomaseizinger Jan 11, 2023
458aa53
Use intermediary variable
thomaseizinger Jan 13, 2023
341d096
Merge branch 'master' into no-run-title-as-command
thomaseizinger Jan 16, 2023
aed5363
refactor(relay): introduce `Handler::new` functions (#3326)
thomaseizinger Jan 16, 2023
5e97d0e
fix: revert "refactor(relay): introduce `Handler::new` functions" (#3…
thomaseizinger Jan 17, 2023
da97e8f
Replace `EitherError` with `Either`
thomaseizinger Jan 17, 2023
2ce805d
Add changelog entry
thomaseizinger Jan 17, 2023
0a2729d
Remove `EitherTransport` in favor of `Either`
thomaseizinger Jan 17, 2023
3397266
Update core/CHANGELOG.md
thomaseizinger Jan 17, 2023
5802177
Merge branch '2650-remove-either-error' into 2650-remove-either-trans…
thomaseizinger Jan 17, 2023
7060f4b
Add changelog entry
thomaseizinger Jan 17, 2023
82eb6c2
Merge branch 'no-run-title-as-command' into 2650-remove-either-error
thomaseizinger Jan 17, 2023
955ff80
Merge branch 'master' into no-run-title-as-command
thomaseizinger Jan 17, 2023
bb84906
Merge branch 'no-run-title-as-command' into 2650-remove-either-error
thomaseizinger Jan 17, 2023
fdfaf72
Merge branch '2650-remove-either-error' into 2650-remove-either-trans…
thomaseizinger Jan 17, 2023
59f6465
Update changelog entry
thomaseizinger Jan 17, 2023
8872039
Remove `EitherUpgrade`
thomaseizinger Jan 17, 2023
d3e79cf
Update core/CHANGELOG.md
thomaseizinger Jan 17, 2023
cefc1c7
Merge branch 'master' into 2650-remove-either-upgrade
thomaseizinger Jan 18, 2023
73666f1
Merge branch 'master' into 2650-remove-either-upgrade
mergify[bot] Jan 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use single quotes to avoid running commands
thomaseizinger committed Jan 11, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 3a84c141787d2206db1ace365fa1b19082d9f00a
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -299,10 +299,10 @@ jobs:

- name: Check PR title length
run: |
title="${{ github.event.pull_request.title }}"
title='${{ github.event.pull_request.title }}'
title_length=${#title}
if [ $title_length -gt 72 ]
then
echo "PR title is too long (greater than 72 characters)"
exit 1
fi
fi