-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ROADMAP.md based on previous feedback. #3091
Conversation
@p-shahi : I'm doing a quick drive-by here. I'm trying to close out from the previous 2 roadmap PRs. I think the main thing is to get a note about interoperability issue. I can also see value in having a persistent rust-libp2p roadmap issue that folks can easily comment on or ask questions (like we have with go and js). |
Should we go with my proposed changes here: #3092 to keep the roadmap more in-line with the Go and JS ones? These are the also the same changes I had made for the EngRes roadmap presentation. |
I commented there, but I think we should roll all of this cleanup into a single PR to make it easier to review/manage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two smaller comments. Otherwise looks good to me.
ROADMAP.md
Outdated
- [Handshake optimizations](#handshake-optimizations) | ||
|
||
### Up Next | ||
- [WebRTC support (browser-to-browser](#2-webrtc-browser-to-browser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the #2-webrtc-browser-to-browser
entry exists in this document. Would you mind adding it in this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a section for it, tentatively put it for sometime Q2 2023.
|
||
|
||
Once WebRTC for browser-to-server is complete, we can begin work on **browser-to-browser** and complete the WebRTC connectivity story. | ||
The specification needs to be written and completed first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical, but it's not specified here or in libp2p/specs#475 why the browser-to-browser work will require changes in rust-libp2p. I assume it's because there are spec additions that we'll want to accommodate, but it may be useful to add a note.
This isn't blocking though for checking this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
Closing out on the open feedback in #2997 and #3062
Open Questions
Verbiage to add around interoperability testing that we're doing right now. go-libp2p can be used for reference: https://github.com/libp2p/go-libp2p/blob/master/ROADMAP.md#benchmarking-and-testing
Commit message body
Minor cleanups and and linking out to the cross-libp2p effort of interoperability testing.