docs(core): Document byte format of PeerId
#3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeerId is more than just a multihash of the public key. See discussion: libp2p#3079
|
@yojoe mind resolving the merge conflicts? |
|
This pull request has merge conflicts. Could you please resolve them @yojoe? 🙏 |
thomaseizinger
changed the title
PeerId
|
I updated the PR description now that #3082 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PeerId data is more than just a multihash of the public key.
See discussion: #3079
Links to any relevant issues
#3079
https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md#keys
Open Questions
Change checklist