identify/handler: Improve property name #2639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nit: Rename
IdentifyHandler.next_id
toIdentifyHandler.trigger_next_identify
to better reflect what it is actually doing.Throughout rust-libp2p, we use
next_*id
for identifiers (e.g.next_connection_id: ConnectionId
).IdentifyHandler.next_id
is not an id, but instead aDelay
that triggers the next outbound substream request, hence the old name is misleading.Change checklist