Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify/handler: Improve property name #2639

Merged

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented May 10, 2022

Description

Nit: Rename IdentifyHandler.next_id to IdentifyHandler.trigger_next_identify to better reflect what it is actually doing.

Throughout rust-libp2p, we use next_*id for identifiers (e.g. next_connection_id: ConnectionId).
IdentifyHandler.next_idis not an id, but instead a Delay that triggers the next outbound substream request, hence the old name is misleading.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • A changelog entry has been made in the appropriate crates
    • don't think a changelog entry is needed for this since it is only internally?

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

That is indeed a much better name :)

@thomaseizinger thomaseizinger changed the title identify/handler: fix misleading property name identify/handler: Improve property name May 11, 2022
@thomaseizinger thomaseizinger merged commit f04f6bb into libp2p:master May 11, 2022
@elenaf9 elenaf9 deleted the identify/fix-misleading-naming branch May 11, 2022 07:04
@mxinden
Copy link
Member

mxinden commented May 11, 2022

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants