misc/multihash: Add Blake2b256 and Blake2s128 #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason that libp2p doesnt use the multihash library? https://github.com/multiformats/rust-multihash |
There was a time when we were very frequently doing changes to multihash, and it would have been very slow to open individual PRs in the multihash repo and wait for them to be merged (the reviewing speed there is... not the quickest). cc #759 |
|
Could someone review this PR？ |
tomaka
approved these changes
Feb 3, 2020
Signed-off-by: koushiro <[email protected]>
|
@tomaka Can you release a new version ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: koushiro [email protected]
Add
Blake2b256andBlake2s128hash types formultihash.