Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support /dnsaddr in multiaddr (and maybe /dns as well?) #967

Closed
tomaka opened this issue Feb 21, 2019 · 3 comments · Fixed by #1356
Closed

Support /dnsaddr in multiaddr (and maybe /dns as well?) #967

tomaka opened this issue Feb 21, 2019 · 3 comments · Fixed by #1356
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:nicetohave

Comments

@tomaka
Copy link
Member

tomaka commented Feb 21, 2019

We don't support multiaddresses with the /dnsaddr component.

The /dns component is marked as "reserved" here, so it's unclear whether it should be implemented or not.

This issue also covers adding support for that in libp2p-dns, or alternatively opening a different issue for adding support in libp2p-dns.
@tomaka tomaka added priority:nicetohave difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Feb 21, 2019
@gnunicorn gnunicorn mentioned this issue Feb 21, 2019
Closed
2 tasks
@raulk
Copy link
Member

raulk commented Feb 21, 2019

go-multiaddr-dns currently handles dns4, dns6, and dnsaddr resolutions. My guess is that dns was reserved as a safeguard to avoid future appropriations that could lead to confusion.

@ghost
Copy link

ghost commented Feb 21, 2019

At the time we weren't certain about the needed scope of /dns, so we marked it reserved and went with /dns4 and /dns6 instead. /dnsaddr is an additional mechanism apart from regular A/AAAA record resolution.

@ackintosh
Copy link
Contributor

Support /dnsaddr

I would like to tackle to this issue. ✨

@ackintosh ackintosh mentioned this issue Dec 20, 2019
Merged
@ackintosh ackintosh mentioned this issue Feb 12, 2020
Closed
@romanb romanb mentioned this issue Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support /dnsaddr in multiaddr ackintosh/rust-libp2p
3 participants
@raulk @tomaka @ackintosh