Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support /dnsaddr in multiaddr #1356

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Support /dnsaddr in multiaddr #1356

merged 4 commits into from
Feb 6, 2020

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Dec 20, 2019 •
edited
Loading

@ackintosh
Copy link
Contributor Author

I am aware that a feature for dnsaddr should be added to transport layer but I'm waiting and see the progress of #1328 as the #1328 has lots of changes. 🤔

@rklaehn
Copy link
Contributor

rklaehn commented Feb 5, 2020

Can this be warmed up? It is needed for reading the default ipfs bootstrap nodes...

I think it is fine to first allow multiaddrs like /dnsaddr/bootstrap.libp2p.io/ipfs/QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN to be parsed without having support for dnsaddr in the networking code. That could happen in a subsequent PR.

@ackintosh
Copy link
Contributor Author

I'm working on this issue. (sorry for the delay...)

cc: @twittner @tomaka
Please leave your comment if it's ok to merge this PR without the transport layer support. 🙏

@tomaka
Copy link
Member

tomaka commented Feb 5, 2020

Yes, it's fine!

@ackintosh ackintosh marked this pull request as ready for review February 5, 2020 12:53
@ackintosh
Merge branch 'master' into dnsaddr
40dfd24 
# Conflicts:
#	misc/multiaddr/tests/lib.rs
@ackintosh
Copy link
Contributor Author

@tomaka Thanks for your comment! I've switched this PR to ready and have fixed conflicts between master.

@tomaka tomaka merged commit 69852a5 into libp2p:master Feb 6, 2020
@ackintosh ackintosh deleted the dnsaddr branch February 7, 2020 06:02
@ackintosh ackintosh mentioned this pull request Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka tomaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support /dnsaddr in multiaddr (and maybe /dns as well?)
3 participants
@ackintosh @rklaehn @tomaka