-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webrtc-websys: __Nonexhaustive does not exist #5557
Comments
## Description Bumps up web-sys version to `0.3.70` fixes #5557 ## Change checklist - [X] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [X] A changelog entry has been made in the appropriate crates --------- Co-authored-by: Darius Clark <[email protected]> Co-authored-by: João Oliveira <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…2p#5569) ## Description Bumps up web-sys version to `0.3.70` fixes libp2p#5557 ## Change checklist - [X] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [X] A changelog entry has been made in the appropriate crates --------- Co-authored-by: Darius Clark <[email protected]> Co-authored-by: João Oliveira <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
I'm running into the same problem when using: |
@mickvandijke No, you need to use the latest patch. I recently asked jxs to publish to crates.io, hopefully will be done soon. Until then, I am using this branch: https://github.com/DougAnderson444/rust-libp2p/tree/webrtc-websys-deps |
Summary
web-sys recently released a patch update which include renaming
__Nonexhaustive
to__Invalid
(see rustwasm/wasm-bindgen#3915), which would cause an compile time error for anyone checking__Nonexhaustive
like we do hererust-libp2p/transports/webrtc-websys/src/stream/poll_data_channel.rs
Line 146 in fc9b1ad
Expected behavior
Not to error when compiling
Actual behavior
Error while compiling using latest patch release
Relevant log output
No response
Possible Solution
While the solution would be to pin the previous patch release, I do feel that we could make a change here by either renaming
__Nonexhaustive
to__Invalid
while updatingweb-sys
to0.3.70
or remove checking__Nonexhaustive
altogether (without updating the dependency) if we do not need to explicitly check it.Version
0.53, 0.54, master
Would you like to work on fixing this bug ?
Maybe
The text was updated successfully, but these errors were encountered: