Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate away from unmaintained actions-rs/toolchain action #3352

Closed
thomaseizinger opened this issue Jan 20, 2023 · 2 comments · Fixed by #3391
Closed

ci: migrate away from unmaintained actions-rs/toolchain action #3352

thomaseizinger opened this issue Jan 20, 2023 · 2 comments · Fixed by #3391
Labels
help wanted priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@thomaseizinger
Copy link
Contributor

Description

https://github.com/actions-rs/toolchain is pretty much unmaintained. It had its last commit in 2020. Our CI generated a lot of warnings due to outdated NodeJS toolchains and deprecated GitHub actions commands. See https://github.com/libp2p/rust-libp2p/actions/runs/3963608745 for example.

We have until June 2023 to migrate away from the deprecated GitHub actions commands: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Motivation

A working CI.

Current Implementation

Are you planning to do it yourself in a pull request?

Maybe.
@thomaseizinger thomaseizinger added priority:important The changes needed are critical for libp2p, or are blocking another project help wanted labels Jan 20, 2023
@thomaseizinger
Copy link
Contributor Author

Tagging this as priority:important because it will block our CI eventually. It is not super urgent, we have until June to fix this.

@leviathanbeak leviathanbeak mentioned this issue Jan 26, 2023
Merged
@thomaseizinger thomaseizinger mentioned this issue Jan 30, 2023
Closed
@thomaseizinger
Copy link
Contributor Author

Opened an issue for the actions-rs/cargo usage: #3398

@mergify mergify bot closed this as completed in #3391 Feb 2, 2023
mergify bot pushed a commit that referenced this issue Feb 2, 2023
@leviathanbeak
fix(ci): replace actions-rs/toolchain with dtolnay/toolchain (#3391)
babf7e3 
This one seems it [got a blessing](rust-lang/regex#883) from rust-lang.

Closes #3352.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): replace actions-rs/toolchain with dtolnay/toolchain leviathanbeak/rust-libp2p
1 participant
@thomaseizinger