Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable Firefox WebTransport interop tests #2930

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Feb 3, 2025

Firefox 134.0 has broken interop as it can no longer dial go-libp2p via WebTransport.

The regression is fixed in Firefox Nightly (136.0) so disable Firefox WebTransport interop testing until that has been released and Playwright has upgraded the version it supports (likely some time in March) or until go-libp2p ships a fix that allows dialling it again.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Firefox 134.0 has broken interop as it can no longer dial go-libp2p.

The regression is fixed in Firefox Nightly (136.0) so disable interop
testing until that has been released and Playwright has upgraded the
version it supports (likely some time in March).
@achingbrain achingbrain requested a review from a team as a code owner February 3, 2025 09:34
@achingbrain achingbrain changed the title chore: disable Firefox interop tests chore: disable Firefox WebTransport interop tests Feb 3, 2025
@achingbrain achingbrain merged commit 15a70af into main Feb 3, 2025
35 checks passed
@achingbrain achingbrain deleted the chore/disable-firefox-interop branch February 3, 2025 10:39
@achingbrain achingbrain mentioned this pull request Feb 3, 2025
achingbrain added a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant