Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unhandled promise rejection when finding gateway #2884

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: unhandled promise rejection when finding gateway #2884

merged 1 commit into from
Dec 10, 2024

Conversation

achingbrain
Copy link
Member

Defer creating the last public ip promise until it's guaranteed to have a a listener for promise rejections.

Fixes ipfs/helia#702

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: unhandled promise rejection when finding gateway
a84bf82 
Defer creating the last public ip promise until it's guaranteed to
have a a listener for promise rejections.

Fixes ipfs/helia#702
@achingbrain achingbrain marked this pull request as ready for review December 10, 2024 08:45
@achingbrain achingbrain requested a review from a team as a code owner December 10, 2024 08:45
@achingbrain achingbrain merged commit 127abe2 into main Dec 10, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the fix/upnp-upr branch December 10, 2024 08:53
@achingbrain achingbrain mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dep bug: @achingbrain/nat-port-mapper -> could not find gateway
1 participant
@achingbrain