Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update packages table #265

Merged
merged 5 commits into from
Sep 3, 2019
Merged

docs: update packages table #265

merged 5 commits into from
Sep 3, 2019

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Oct 25, 2018

@ghost ghost assigned vasco-santos Oct 25, 2018
@ghost ghost added the status/in-progress In progress label Oct 25, 2018
@vasco-santos
Copy link
Member Author

Regarding the not implemented packages:

  • libp2p-udp
  • libp2p-udt
  • p2pcat

Should we remove them from the table?

And what about libp2p-secio?

@jacobheun
Copy link
Contributor

libp2p-secio has a lead maintainer but since it hasn't been published to npm since the field was added it's registering as unavailable. The lead maintainer won't show up until the package is published.

@daviddias
Copy link
Member

@jacobheun fixing that now by releasing a patch version with updated deps :)

@daviddias
Copy link
Member

Regarding the not implemented packages:

@vasco-santos agreed, remove packages that are not implemented at all

@vasco-santos
Copy link
Member Author

I removed the not implemented packages and updated the lead maintainer for libp2p-secio.

Now me and Jacob only need to create the PRs for the remaining repos

@vasco-santos
Copy link
Member Author

For finishing this, me and @jacobheun do not have write access to the following repos:

libp2p/interface-peer-discovery
libp2p/interface-peer-routing
libp2p/interface-record-store
libp2p/interface-connection
libp2p/interface-transport
libp2p/interface-stream-muxer
libp2p/js-libp2p-nat-mngr

The right teams probably weren't added to the repos. @libp2p/dx can you make sure the right teams are added to this repo?

@daviddias
Copy link
Member

@vasco-santos just added the JavaScript team to all of them

@daviddias
Copy link
Member

@vasco-santos This update should be done through https://github.com/libp2p/js-libp2p/blob/master/package-list.json vs. updating on the README directly

@daviddias
Copy link
Member

@vasco-santos updated it for you :)

@jacobheun, @vasco-santos now that some many parts of the core pieces are integrated, I believe that we can collapse it even more by:

  • Merging peer-id and peer-info into a peer module
  • Bringing peer-book into js-libp2p, given that it is only used inside of it.

@vasco-santos
Copy link
Member Author

Thanks @daviddias ! :D

I am planning to work on the peer-* refactor as soon as I get into the Peer store v2 work

@vasco-santos vasco-santos changed the title [WIP] docs: update packages table docs: update packages table Sep 2, 2019
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a swap file was accidentally added in the last commit, ./package-list.json.swp, I'll remove it. Other than that, the changes look good.

@jacobheun jacobheun merged commit 5b1bd38 into master Sep 3, 2019
@jacobheun jacobheun deleted the docs/update-packages-table branch September 3, 2019 08:29
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
## [6.1.6](libp2p/js-libp2p-tcp@v6.1.5...v6.1.6) (2023-04-12)

### Bug Fixes

* on MultiaddrConnection close() only create timer if needed ([libp2p#262](libp2p/js-libp2p-tcp#262)) ([3637489](libp2p/js-libp2p-tcp@3637489))

### Dependencies

* bump @libp2p/interface-connection from 3.1.1 to 4.0.0 ([libp2p#265](libp2p/js-libp2p-tcp#265)) ([d2ef2d0](libp2p/js-libp2p-tcp@d2ef2d0))
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Bumps [it-foreach](https://github.com/achingbrain/it) from 1.0.1 to 2.0.2.
- [Release notes](https://github.com/achingbrain/it/releases)
- [Commits](achingbrain/it@it-foreach-v1.0.1...it-foreach-v2.0.2)

---
updated-dependencies:
- dependency-name: it-foreach
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
## [7.1.6](libp2p/js-libp2p-mplex@v7.1.5...v7.1.6) (2023-04-13)

### Dependencies

* **dev:** bump it-all from 2.0.1 to 3.0.1 ([libp2p#260](libp2p/js-libp2p-mplex#260)) ([c63ed58](libp2p/js-libp2p-mplex@c63ed58))
* **dev:** bump it-foreach from 1.0.1 to 2.0.2 ([libp2p#265](libp2p/js-libp2p-mplex#265)) ([76d27a4](libp2p/js-libp2p-mplex@76d27a4))
* **dev:** bump it-pipe from 2.0.5 to 3.0.1 ([libp2p#268](libp2p/js-libp2p-mplex#268)) ([bd37717](libp2p/js-libp2p-mplex@bd37717))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all libp2p packages have lead maintainters
3 participants