Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev install with Node.js 10 #205

Closed
wants to merge 1 commit into from
Closed

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jun 20, 2018

This adds ~ to the wrtc devDependency so that we get version 0.1.5 when installing (which has prebuilt binaries for Node.js 10).

fixes #204

I'm currently getting the following test failures, which I'm also getting when running the tests against master with Node.js 9 and wrtc 0.1.1.

  1) transports
       TCP + WebSockets + WebRTCStar
         nodeAll.dial nodeWStar using PeerInfo:
     Uncaught AssertionError: expected [Error: Circuit not enabled and all transports failed to dial peer QmZMmzaApGcrdB1iM7okN6ywHkevsxo2NotXPCrX44vHkp!] to not exist
      at nodeAll.dial (test/transports.node.js:497:28)
      at Dialer.switch.dial [as callback] (src/index.js:239:27)
      at waterfall (node_modules/libp2p-switch/src/dial.js:110:12)
      at node_modules/async/internal/once.js:12:16
      at next (node_modules/async/waterfall.js:21:29)
      at node_modules/async/internal/onlyOnce.js:12:16
      at waterfall (node_modules/libp2p-switch/src/dial.js:151:7)
      at node_modules/async/internal/once.js:12:16
      at next (node_modules/async/waterfall.js:21:29)
      at node_modules/async/internal/onlyOnce.js:12:16
      at waterfall (node_modules/libp2p-switch/src/dial.js:189:16)
      at node_modules/async/internal/once.js:12:16
      at next (node_modules/async/waterfall.js:21:29)
      at node_modules/async/internal/onlyOnce.js:12:16
      at nextTransport (node_modules/libp2p-switch/src/dial.js:322:18)
      at switch.transport.dial (node_modules/libp2p-switch/src/dial.js:339:18)
      at dialer.dialMany (node_modules/libp2p-switch/src/transport.js:69:16)
      at f (node_modules/once/once.js:25:25)
      at map (node_modules/libp2p-switch/src/limit-dialer/index.js:61:14)
      at node_modules/async/internal/map.js:32:9
      at node_modules/async/internal/once.js:12:16
      at iteratorCallback (node_modules/async/eachOf.js:60:13)
      at node_modules/async/internal/onlyOnce.js:12:16
      at Object.callback (node_modules/async/internal/map.js:29:13)
      at node_modules/async/internal/queue.js:101:31
      at node_modules/async/internal/onlyOnce.js:12:16
      at _dialWithTimeout (node_modules/libp2p-switch/src/limit-dialer/queue.js:44:16)
      at Timeout.timeoutCallback [as _onTimeout] (node_modules/async/timeout.js:74:13)

  2) transports
       TCP + WebSockets + WebRTCStar
         nodeAll.hangUp nodeWStar using PeerInfo:

      Uncaught AssertionError: expected [ Array(2) ] to have a length of 3 but got 2
      + expected - actual

      -2
      +3
      
      at forEach (test/transports.node.js:455:61)
      at Array.forEach (<anonymous>)
      at check (test/transports.node.js:454:28)
      at Timeout.setTimeout [as _onTimeout] (test/transports.node.js:506:26)

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@ghost ghost assigned alanshaw Jun 20, 2018
@ghost ghost added the status/in-progress In progress label Jun 20, 2018
@daviddias
Copy link
Member

@alanshaw see why wrtc was 0.1.1 -- #194

I've also tested with simple-peer and webrtc-star and wrtc also makes them fail - #193 (comment)

@daviddias
Copy link
Member

We either disable the tests with wrtc for Node.js 10 or stop testing with Node.js 10. Having CI red is a nono.

@alanshaw
Copy link
Member Author

We can't disable the tests because it fails at install time. I think we need to add a custom set of node versions to our ci/Jenkinsfile excluding Node.js 10 until wrtc is fixed.

@alanshaw alanshaw closed this Jun 27, 2018
@ghost ghost removed the status/in-progress In progress label Jun 27, 2018
@daviddias daviddias deleted the fix/tilde-wrtc-dep branch June 27, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot npm install with Node.js 10 -> Missing wrtc builds for Node.js 10
2 participants