fix: do not auto-dial connected peers #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting peers to auto-dial, exclude peers we are already connected to in order to not swamp the dial queue with pointless dials. This makes browsers run a bit faster.
Merged
wemeetagain
approved these changes
May 4, 2023
maschad
approved these changes
May 4, 2023
achingbrain
added a commit
that referenced
this pull request
May 5, 2023
Similar to #1730, filter auto-dial peers by peers already in the dial queue. The dial queue will join any pre-existing dial attempts for the selected peers, but it just creates unnecessary work and adds noise to the logs and filtering them out beforehand is cheap so just do that.
achingbrain
added a commit
that referenced
this pull request
May 9, 2023
Similar to #1730, filter auto-dial peers by peers already in the dial queue. The dial queue will join any pre-existing dial attempts for the selected peers, but it just creates unnecessary work and adds noise to the logs and filtering them out beforehand is cheap so just do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting peers to auto-dial, exclude peers we are already connected to in order to not swamp the dial queue with pointless dials. This reduces the amount of work browsers in particular have to do.