stats: exposed and documented #169

pgte · 2018-02-23T13:25:21Z

Fixes #168

victorb · 2018-02-23T13:30:23Z

test/stats.js

+
+describe('libp2p', (done) => {
+  it('has stats', () => {
+    createNode('/ip4/0.0.0.0/tcp/0', {


Probably want to set address to 127.0.0.1 instead, no reason to bind to public interface :)

@victorbjelkholm good call, thanks! Fixed by 10bd08b.

hacdias · 2018-02-27T17:05:15Z

@pgte just updated the version of libp2p-switch on package.json to see if the tests work 😄

hacdias · 2018-03-03T16:31:33Z

Any updates here?

daviddias

CI is all failing.

hacdias · 2018-03-04T08:19:02Z

The tests seem to be failing on some (not directly) related code to stats:

js-libp2p/test/peer-routing.node.js

Lines 52 to 60 in 7eb1166

    
           after((done) => { 
        
             parallel([ 
        
               (cb) => nodeA.stop(cb), 
        
               (cb) => nodeB.stop(cb), 
        
               (cb) => nodeC.stop(cb), 
        
               (cb) => nodeD.stop(cb), 
        
               (cb) => nodeE.stop(cb) 
        
             ], done) 
        
           })

/cc @pgte

daviddias · 2018-03-06T12:27:00Z

@dryajov did something change on circuit-relay?

hacdias · 2018-03-09T15:06:23Z

Ping @pgte

pgte · 2018-03-09T16:15:02Z

@hacdias my build runs locally, but I'm trying to figure out what's happening on CI..

daviddias · 2018-03-09T22:19:04Z

@pgte suggestion: try to rebase master onto this branch, it might solve your issue.

hacdias · 2018-03-11T18:08:36Z

@pgte @diasdavid just rebased into master and the issue persists. I'm using the last commit from here on ipfs/js-ipfs#1230 and it seems to be working well.

daviddias · 2018-03-12T09:09:49Z

This one is stale for a while, what's blocking from getting CI green?

pgte · 2018-03-12T09:11:53Z

Working on this now.

pgte · 2018-03-12T10:37:23Z

Related: libp2p/js-libp2p-switch#246

pgte · 2018-03-12T10:46:15Z

I cannot reproduce this locally, but the error traces suggest that this PR for libp2p-switch should ameliorate this.

daviddias · 2018-03-12T15:05:50Z

restarted CI now that libp2p-switch fix has been merged and released as a patch version.

pgte · 2018-03-12T15:33:21Z

@diasdavid thanks! That fixed some issues, but now I have node v6-only failings I'm going to dive into..

pgte · 2018-03-12T16:15:45Z

Update: for some reason, in node.js v6, in some instances, peerInfo.id is a buffer and not a peer-id instance..

pgte · 2018-03-12T16:54:37Z

I think I found the problem, and it's in libp2p-circuit: libp2p/js-libp2p-circuit#23

If ok, needs updating libp2p-circuit and downstream libp2p-switch and libp2p.

daviddias

Let's see if it runs now :)

daviddias · 2018-03-15T02:53:38Z

@pgte a new consistent error as arise: https://travis-ci.org/libp2p/js-libp2p/builds/353334562#L4862

pgte · 2018-03-15T08:53:15Z

One last edge case fixed in the switch observer: libp2p/js-libp2p-switch#248

It should all be ok after this switch fix:

Bumps [@multiformats/multiaddr](https://github.com/multiformats/js-multiaddr) from 11.6.1 to 12.0.0. - [Release notes](https://github.com/multiformats/js-multiaddr/releases) - [Changelog](https://github.com/multiformats/js-multiaddr/blob/master/CHANGELOG.md) - [Commits](multiformats/js-multiaddr@v11.6.1...v12.0.0) --- updated-dependencies: - dependency-name: "@multiformats/multiaddr" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

## [6.0.2](libp2p/js-libp2p-bootstrap@v6.0.1...v6.0.2) (2023-03-17) ### Dependencies * bump @multiformats/multiaddr from 11.6.1 to 12.0.0 ([libp2p#169](libp2p/js-libp2p-bootstrap#169)) ([3532982](libp2p/js-libp2p-bootstrap@3532982))

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

## [2.0.9](libp2p/js-libp2p-webrtc@v2.0.8...v2.0.9) (2023-06-12) ### Dependencies * **dev:** bump delay from 5.0.0 to 6.0.0 ([libp2p#169](libp2p/js-libp2p-webrtc#169)) ([104cbf0](libp2p/js-libp2p-webrtc@104cbf0))

## [3.0.3](libp2p/js-libp2p-floodsub@v3.0.2...v3.0.3) (2022-08-03) ### Dependencies * update project deps to support no-copy operations ([#169](libp2p/js-libp2p-floodsub#169)) ([6a129b7](libp2p/js-libp2p-floodsub@6a129b7))

ghost assigned pgte Feb 23, 2018

ghost added the status/in-progress In progress label Feb 23, 2018

pgte requested a review from daviddias February 23, 2018 13:25

victorb reviewed Feb 23, 2018

View reviewed changes

ghost assigned hacdias Feb 27, 2018

hacdias mentioned this pull request Feb 27, 2018

feat: .stats.bw* - Bandwidth Stats ipfs/js-ipfs#1230

Merged

9 tasks

daviddias approved these changes Mar 3, 2018

View reviewed changes

daviddias suggested changes Mar 3, 2018

View reviewed changes

hacdias force-pushed the feat/stats branch from 7eb1166 to 09069d4 Compare March 11, 2018 15:23

pgte force-pushed the feat/stats branch from 09069d4 to 52b4f76 Compare March 12, 2018 10:05

pgte mentioned this pull request Mar 12, 2018

fix: switch observer edge cases libp2p/js-libp2p-switch#246

Merged

pgte mentioned this pull request Mar 13, 2018

fix: creating a proper peerId instead of using a simple buffer or string libp2p/js-libp2p-circuit#23

Merged

daviddias force-pushed the feat/stats branch from 52b4f76 to d7c26c6 Compare March 14, 2018 13:37

ghost assigned daviddias Mar 14, 2018

daviddias approved these changes Mar 14, 2018

View reviewed changes

pgte added 2 commits March 15, 2018 08:06

stats: exposed and documented

3e997a6

stats: tests: bind to localhost only

05f2a36

daviddias force-pushed the feat/stats branch from d7c26c6 to 05f2a36 Compare March 15, 2018 15:06

daviddias merged commit 4527d5f into master Mar 15, 2018

daviddias deleted the feat/stats branch March 15, 2018 15:10

ghost removed the status/in-progress In progress label Mar 15, 2018

snyk-bot mentioned this pull request Apr 8, 2022

[Snyk] Fix for 1 vulnerabilities adamlaska/js-libp2p#22

Open

maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023

deps(dev): bump delay from 5.0.0 to 6.0.0 (libp2p#169)

104cbf0

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

achingbrain added a commit that referenced this pull request Jun 27, 2023

deps: update project deps to support no-copy operations (#169)

6a129b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stats: exposed and documented #169

stats: exposed and documented #169

pgte commented Feb 23, 2018

victorb Feb 23, 2018

pgte Feb 23, 2018

hacdias commented Feb 27, 2018

hacdias commented Mar 3, 2018

daviddias left a comment

hacdias commented Mar 4, 2018 •

edited

Loading

daviddias commented Mar 6, 2018

hacdias commented Mar 9, 2018

pgte commented Mar 9, 2018

daviddias commented Mar 9, 2018

hacdias commented Mar 11, 2018

daviddias commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

daviddias commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

daviddias left a comment

daviddias commented Mar 15, 2018

pgte commented Mar 15, 2018

stats: exposed and documented #169

stats: exposed and documented #169

Conversation

pgte commented Feb 23, 2018

victorb Feb 23, 2018

Choose a reason for hiding this comment

pgte Feb 23, 2018

Choose a reason for hiding this comment

hacdias commented Feb 27, 2018

hacdias commented Mar 3, 2018

daviddias left a comment

Choose a reason for hiding this comment

hacdias commented Mar 4, 2018 • edited Loading

daviddias commented Mar 6, 2018

hacdias commented Mar 9, 2018

pgte commented Mar 9, 2018

daviddias commented Mar 9, 2018

hacdias commented Mar 11, 2018

daviddias commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

daviddias commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

pgte commented Mar 12, 2018

daviddias left a comment

Choose a reason for hiding this comment

daviddias commented Mar 15, 2018

pgte commented Mar 15, 2018

hacdias commented Mar 4, 2018 •

edited

Loading