Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libp2p-switch #161

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Update to libp2p-switch #161

merged 2 commits into from
Feb 7, 2018

Conversation

daviddias
Copy link
Member

No description provided.

@ghost ghost assigned daviddias Feb 7, 2018
@ghost ghost added the status/in-progress In progress label Feb 7, 2018
@daviddias daviddias merged commit cd43863 into master Feb 7, 2018
@daviddias daviddias deleted the update-to-switch branch February 7, 2018 07:31
@ghost ghost removed the status/in-progress In progress label Feb 7, 2018
@@ -39,7 +39,7 @@
"dependencies": {
"async": "^2.6.0",
"libp2p-ping": "~0.6.0",
"libp2p-swarm": "~0.35.1",
"libp2p-switch": "~0.36.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this reset versioning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a good question - I was thinking along the lines of once the name of the module changes, it might be worth resetting the version, but thinking some more I realize that there is no benefit in doing that. nvm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants