Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: broken @libp2p/interface-compliance-tests #1974

Closed
danisharora099 opened this issue Aug 16, 2023 · 0 comments · Fixed by #1983 or waku-org/js-waku#1525
Closed

bug: broken @libp2p/interface-compliance-tests #1974

danisharora099 opened this issue Aug 16, 2023 · 0 comments · Fixed by #1983 or waku-org/js-waku#1525
Assignees
@maschad
Labels
need/triage Needs initial labeling and prioritization

Comments

@danisharora099
Copy link

  • Version: 0.46.3

  • Platform: macos

  • Subsystem: compliance tests

Severity: high

Description:

on the upgrade of @libp2p/interface-peer-discovery-compliance-tests to @libp2p/[email protected] the package breaks because aegir is installed as a dev dependency on the latter while it's needed to run tests which was installed as a dependency on the former package.

the solution can be simply moving aegir to dependency or to install chai as a dependency and using that instead of aegir/chai?
@danisharora099 danisharora099 added the need/triage Needs initial labeling and prioritization label Aug 16, 2023
This was referenced Aug 16, 2023
Merged
Merged
@maschad maschad moved this to 🛠️ Todo in js-libp2p Aug 20, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Aug 20, 2023
@maschad
deps: move aegir from dev deps to deps (libp2p#1974)
1b45e91
@maschad maschad mentioned this issue Aug 20, 2023
Merged
@maschad maschad moved this from 🛠️ Todo to 🥸In Review in js-libp2p Aug 20, 2023
achingbrain added a commit that referenced this issue Aug 24, 2023
@achingbrain
fix(@libp2p/interface-compliance-tests): make ageir a dep
6504b2e 
The interface compliance tests depend on aegir to run the tests so
make it a dep instead of a dev dep.

Fixes #1974
@achingbrain achingbrain mentioned this issue Aug 24, 2023
Closed
achingbrain pushed a commit that referenced this issue Aug 24, 2023
@maschad
fix(@libp2p/interface-compliance-tests): add aegir to deps (#1983)
8977862 
Given that this package is primarily responsible for testing, I think that `aegir` is required as a dependency to utilize it properly.

Closes #1974
@github-project-automation github-project-automation bot moved this from 🥸In Review to 🎉Done in js-libp2p Aug 24, 2023
@danisharora099 danisharora099 mentioned this issue Sep 2, 2023
Merged
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
need/triage Needs initial labeling and prioritization
Projects
js-libp2p
Archived in project
Milestone
No milestone
2 participants
@maschad @danisharora099