fix: return info on removed key #10

libp2p · Dec 8, 2017 · f49e753 · f49e753
1 parent 506e1d7
commit f49e753
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/keychain.js b/src/keychain.js
@@ -186,11 +186,12 @@ class Keychain {
       return _error(callback, `Invalid key name '${name}'`)
     }
     const dsname = DsName(name)
-    self.store.has(dsname, (err, exists) => {
+    self._getKeyInfo(name, (err, keyinfo) => {
       if (err) return _error(callback, err)
-      if (!exists) return _error(callback, `Key '${name}' does not exist'`)
-
-      self.store.delete(dsname, callback)
+      self.store.delete(dsname, (err) => {
+        if (err) return _error(callback, err)
+        callback(null, keyinfo)
+      })
     })
   }
 

diff --git a/test/keychain.spec.js b/test/keychain.spec.js
@@ -345,8 +345,11 @@ module.exports = (datastore1, datastore2) => {
       })
 
       it('can remove a known key', (done) => {
-        ks.removeKey(renamedRsaKeyName, (err) => {
+        ks.removeKey(renamedRsaKeyName, (err, key) => {
           expect(err).to.not.exist()
+          expect(key).to.exist()
+          expect(key).to.have.property('name', renamedRsaKeyName)
+          expect(key).to.have.property('id', rsaKeyInfo.id)
           done()
         })
       })