Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Disconnection events are not emitted #138

Closed
marcus-pousette opened this issue Apr 24, 2023 · 2 comments · Fixed by #134
Closed

Disconnection events are not emitted #138

marcus-pousette opened this issue Apr 24, 2023 · 2 comments · Fixed by #134
Assignees
@maschad
Labels
bug Something isn't working

Comments

@marcus-pousette
Copy link
Contributor

marcus-pousette commented Apr 24, 2023 •
edited
Loading

To reproduce

Running the demo, put a log in node.addEventListener("peer:disconnect", ... . The event is never emitted if one closes one of the tabs.

This is creating severe issues for me when using this transport as I can not manage connections properly in my protocol handler.
@p-shahi p-shahi added the bug Something isn't working label Apr 24, 2023
@p-shahi
Copy link
Member

p-shahi commented Apr 24, 2023 •
edited
Loading

@marcus-pousette We are aware of the issue and working on a fix here: #134

Running the demo

The browser to browser demo?

@marcus-pousette
Copy link
Contributor Author

@marcus-pousette We are aware of the issue and working on a fix here: #134

Aha! Great. I missed that.

The browser to browser demo?

Yes

@maschad maschad self-assigned this Apr 24, 2023
@maschad maschad mentioned this issue Apr 24, 2023
Merged
maschad added a commit that referenced this issue Apr 24, 2023
@maschad
fix: updated listening event name for disconnect/closed events (#138)
4f52d2d
maschad added a commit that referenced this issue Apr 25, 2023
@maschad
fix: removed listener once connection is closed (#138)
1a9d6e1
maschad added a commit that referenced this issue Apr 25, 2023
@maschad
fix: removed listener once connection is closed (#138)
fb89a2d
MarcoPolo pushed a commit that referenced this issue Apr 25, 2023
@maschad
fix: added peer connection state listener to emit closed events (#134)
16e8503 
* fix: added peer connection state listener to emit closed events

* fix: updated listening event name for disconnect/closed events (#138)

* fix: removed listener once connection is closed (#138)

* fix: removed listener once connection is closed (#138)
github-actions bot pushed a commit that referenced this issue Apr 25, 2023
@semantic-release-bot
chore(release): 1.1.8 [skip ci]
de4d45e 
## [1.1.8](v1.1.7...v1.1.8) (2023-04-25)

### Bug Fixes

* added peer connection state listener to emit closed events ([#134](#134)) ([16e8503](16e8503)), closes [#138](#138) [#138](#138) [#138](#138)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maschad maschad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added peer connection state listener to emit closed events libp2p/js-libp2p-webrtc
3 participants
@maschad @marcus-pousette @p-shahi