fix: allow overwriting tags (#68)

Allows setting the same tag twice, last update wins. Otherwise trying to ensure atomic writes becomes very hard.
libp2p · Mar 2, 2023 · 4182211 · 4182211
1 parent 0b5e25f
commit 4182211
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -135,11 +135,8 @@ export class PersistentPeerStore extends EventEmitter<PeerStoreEvents> implement
       tags = Tags.decode(buf).tags
     }
 
-    for (const t of tags) {
-      if (t.name === tag) {
-        throw new CodeError('Peer already tagged', 'ERR_DUPLICATE_TAG')
-      }
-    }
+    // do not allow duplicate tags
+    tags = tags.filter(t => t.name !== tag)
 
     tags.push({
       name: tag,

diff --git a/test/peer-store.spec.ts b/test/peer-store.spec.ts
@@ -288,10 +288,18 @@ describe('peer-store', () => {
 
     it('does not tag a peer twice', async () => {
       const name = 'a-tag'
-      await peerStore.tagPeer(peerIds[0], name)
+      await peerStore.tagPeer(peerIds[0], name, {
+        value: 1
+      })
+      await peerStore.tagPeer(peerIds[0], name, {
+        value: 10
+      })
+
+      const allTags = await peerStore.getTags(peerIds[0])
+      const tags = allTags.filter(t => t.name === name)
 
-      await expect(peerStore.tagPeer(peerIds[0], name), 'PeerStore allowed duplicate tags')
-        .to.eventually.be.rejected().with.property('code', 'ERR_DUPLICATE_TAG')
+      expect(tags).to.have.lengthOf(1)
+      expect(tags).to.have.nested.property('[0].value', 10)
     })
 
     it('untags a peer', async () => {