This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: update deps #217
Merged
chore: update deps #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/update-deps-12-04-2021
branch
from
ccaee63
to
8d11ebf
Compare
6 tasks
vasco-santos
force-pushed
the
chore/update-deps-12-04-2021
branch
from
8d11ebf
to
fc55da5
Compare
vasco-santos
force-pushed
the
chore/update-deps-12-04-2021
branch
from
fc55da5
to
da8ce0c
Compare
77 tasks
achingbrain
reviewed
Apr 17, 2021
achingbrain
reviewed
Apr 17, 2021
achingbrain
approved these changes
Apr 17, 2021
Co-authored-by: Alex Potsides <[email protected]>
achingbrain
reviewed
Apr 19, 2021
Co-authored-by: Alex Potsides <[email protected]>
…ibp2p-kad-dht into chore/update-deps-12-04-2021
Closed
18 tasks
achingbrain
approved these changes
Apr 28, 2021
|
LGTM, pending green CI |
|
Prior to libp2p/js-libp2p@b4fb9b7 the event was emitted with empty addresses, which meant the findPeer was working, but no addresses existed. In addition, test dht connect now also adds to the addressBook the peer addresses onConnect, as libp2p would do if we were using its dialer. Also, if self peer receives findPeer query, it was not returning its multiaddrs 🤦🏼 |
achingbrain
approved these changes
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies, switch from protons to protobufjs as the rest of the stack
aegirsince 31+ does not close the test process if there are outstanding resources being used. This is great as we are able to catch new errors easily. There is a known error where queries are not properly closed which means the tests will not be closed in the end. I am deferring this fix to a follow up PR (need to check if we have an issue, otherwise create one)Needs: