Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Bug Fix: rename query.run object to not overwrite query.run method #115

Closed
wants to merge 0 commits into from

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented May 10, 2019

Fixes #114

@ghost ghost assigned kumavis May 10, 2019
@ghost ghost added the status/in-progress In progress label May 10, 2019
@kumavis kumavis changed the title Bug fix: rename query.run object to not overwrite query.run method Bug Fix: rename query.run object to not overwrite query.run method May 10, 2019
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, this looks good. Might be worth revisiting the naming of Run in the future to make the query logic easier to consume.

@jacobheun jacobheun requested a review from vasco-santos May 10, 2019 07:56
@vasco-santos vasco-santos force-pushed the fix/query-run-collision branch from 704a363 to 0932754 Compare May 10, 2019 09:40
@ghost ghost assigned vasco-santos May 10, 2019
@ghost ghost removed the status/in-progress In progress label May 10, 2019
@vasco-santos
Copy link
Member

vasco-santos commented May 10, 2019

The changes were integrated in #116 and this was released

@vasco-santos vasco-santos deleted the fix/query-run-collision branch May 10, 2019 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query - run is overwritten
3 participants