This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix: make outbound peer id optional #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support connecting to mulitaddrs without a peer id make the remote peer id an optional argument when securing the outbound connection.
mpetrunic
approved these changes
Sep 30, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
## [@libp2p/interface-connection-encrypter-v2.0.2](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-connection-encrypter-v2.0.1...@libp2p/interface-connection-encrypter-v2.0.2) (2022-09-30) ### Bug Fixes * make outbound peer id optional ([#294](#294)) ([6724ffe](6724ffe))
|
🎉 This PR is included in version @libp2p/interface-connection-encrypter-v2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
achingbrain
added a commit
to achingbrain/js-libp2p-noise
that referenced
this pull request
Oct 3, 2022
libp2p/js-libp2p-interfaces#294 made the outbound peer id optional in the connection encrypter interface so apply that change to the noise codebase.
|
@marin follow-up PR to noise here - ChainSafe/js-libp2p-noise#218 |
mpetrunic
pushed a commit
to ChainSafe/js-libp2p-noise
that referenced
this pull request
Oct 3, 2022
libp2p/js-libp2p-interfaces#294 made the outbound peer id optional in the connection encrypter interface so apply that change to the noise codebase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support connecting to mulitaddrs without a peer id make the remote peer id an optional argument when securing the outbound connection.