-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
bb58bd2
to
11f964c
Compare
|
||
> A test suite you can use to implement a libp2p crypto module. A libp2p crypto module is used to ensure all exchanged data between two peers is encrypted. | ||
|
||
**Modules that implement the interface** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is plaintext not going to be a module?
Edit: It would be useful to have it as one, so people who want to experiment with it can simply add it like "just another crypto module"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the intent, I'm planning on writing that and the private network refactor this week. I was planning on just bundling plaintext 2 with libp2p though, and linking to it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, perfect. I'll keep this discussion open until that's resolved for tracking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also created #3 to track adding plaintext.
feat: add errors export
I've updated the docs and added a test for the expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just found a small typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I assume that with |
Co-Authored-By: Vasco Santos <[email protected]>
Yes, that's correct. Now when you dial in libp2p the |
This adds a crypto interface to js libp2p, we currently don't have one. This also includes a mock crypto file for tests, which demonstrates how a crypto module might be built, including a handshake and stream wrapping which can be used for crypto boxing/unboxing.
Aside from the clear change to async iterables, this also updates the "existing" interface to use the
protocol
property instead oftag
to be clearer about its purpose.I added the iterable wrapper logic to the js-libp2p docs in a PR, in case it's useful to others libp2p/js-libp2p#466