check deadline before sending a message #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -487,6 +487,8 @@ func (s *Session) sendMsg(hdr header, body []byte, deadline <-chan struct{}) err | |||
| select { | |||
| case <-s.shutdownCh: | |||
| return s.shutdownErr | |||
| case <-deadline: | |||
| return ErrTimeout | |||
There was a problem hiding this comment.
Should this be a separate select statement after this one?
There was a problem hiding this comment.
Yes, you are right, the shutdownErr should preferred.
…it will write successfully after deadline Signed-off-by: Asutorufa <[email protected]>
marten-seemann
approved these changes
Dec 13, 2023
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check deadline before sendMsg, because select is randomly, sometimes it will write successfully after deadline