This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
move deps into gx #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whyrusleeping add a Makefile? we should have a standard:
|
|
|
||
| ## Dependencies | ||
| go-stream-muxer uses gx to manage vendored dependencies. While this package may | ||
| work just fine without the vendored deps, to avoid upstream changes breaking |
There was a problem hiding this comment.
while this package may work just fine without the vendored deps
what does this mean? how could it work without the deps?
|
@jbenet changed the paths to the gx paths |
| @@ -5,7 +5,7 @@ package multistream | |||
| import ( | |||
| "net" | |||
|
|
|||
| mss "github.com/whyrusleeping/go-multistream" | |||
| mss "gx/ipfs/Qmf91yhgRLo2dhhbc5zZ7TxjMaR1oxaWaoc9zRZdi1kU4a/go-multistream" | |||
There was a problem hiding this comment.
@whyrusleeping this is fine with me but is not go-gettable. paths can be:
mss "ipfs.io/ipfs/Qmf91yhgRLo2dhhbc5zZ7TxjMaR1oxaWaoc9zRZdi1kU4a/go-multistream"
no?
or similarly:
mss "gx.io/ipfs/Qmf91yhgRLo2dhhbc5zZ7TxjMaR1oxaWaoc9zRZdi1kU4a/go-multistream"
There was a problem hiding this comment.
When we get to the point where thats actually possible we can discuss switching to that, but for now its non-trivial to be able to go-get gx packages.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has #6 as a prereq to make things easier on me