This repository has been archived by the owner on Jan 7, 2023. It is now read-only.
fix: unsafe pointer passing #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use github.com/mattn/go-pointer to save/restore "pointers" across FFI bounderies. Go reserves the right to move pointers, so using `unsafe.Pointer` for this is not safe.
marten-seemann
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Assuming that mattn/go-pointer does the right thing (and we're not just moving the stuff that go vet is complaining about into a 3rd party dependency, which go vet then doesn't see any more), this LGTM.
Unfortunately, the README of that repo is not very enlightening.
|
It's doing the right thing. Basically, it's:
|
oleg-jukovec
added a commit
to oleg-jukovec/go-openssl
that referenced
this pull request
May 31, 2022
The error occurs when trying to build the library using go < 1.16: ./alloc.go:14:10: unrecognized Go type _Ctype_void ./alloc.go:16:21: unrecognized Go type _Ctype_void This is an unnecessary restriction. It can be fixed by replacing *C.void with unsafe.Pointer (as it is already done for `ptr` argument of CRYPTO_EX_free[1][2]). 1. https://www.openssl.org/docs/manmaster/man3/SSL_get_ex_new_index.html 2. https://www.openssl.org/docs/man3.0/man3/CRYPTO_EX_free.html Related to libp2p#18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use github.com/mattn/go-pointer to save/restore "pointers" across FFI bounderies. Go reserves the right to move pointers, so using
unsafe.Pointerfor this is not safe.