Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using syscall.RtMsg on Linux #43

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Using syscall.RtMsg on Linux #43

merged 1 commit into from
Feb 27, 2024

Conversation

7sunarni
Copy link
Contributor

@7sunarni 7sunarni commented Feb 26, 2024

I think we don't need to define struct routeInfoInMemory because there is already defined struct sycall.RtMsg in Golang standard library

@7sunarni
Copy link
Contributor Author

@willscott

@willscott
Copy link
Contributor

I think this would mean the library couldn't be used on arm devices, right? - I see RtMsg in the arm64 types, but it isn't there for the arm definitions that would be used for e.g. older raspberry pi's / other armv6/armv7 chips.

I appreciate the simplification - are there other benefits to consider in whether it's worth using the partial upstream definition?

@7sunarni
Copy link
Contributor Author

I think this would mean the library couldn't be used on arm devices, right? - I see RtMsg in the arm64 types, but it isn't there for the arm definitions that would be used for e.g. older raspberry pi's / other armv6/armv7 chips.

I think you may miss something. There is also RtMsg definition in arm. So i think it could run in other arm chips.

are there other benefits to consider in whether it's worth using the partial upstream definition?

Temporary no.

@willscott
Copy link
Contributor

you're right! my search missed the arm one. this seems unobjectionable 👍

@willscott willscott merged commit 57cc4df into libp2p:master Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants