Merge pull request #4 from libp2p/fix/pool-ref

make ByteSlicePool a *Pool, not a Pool.
libp2p · Nov 21, 2017 · e1d4bc0 · e1d4bc0
2 parents fa984f5 + 4de8afb
commit e1d4bc0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/mpool/pool.go b/mpool/pool.go
@@ -26,12 +26,10 @@ import (
 )
 
 // ByteSlicePool is a static Pool for reusing byteslices of various sizes.
-var ByteSlicePool Pool
-
-func init() {
-	ByteSlicePool.New = func(length int) interface{} {
+var ByteSlicePool = &Pool{
+	New: func(length int) interface{} {
 		return make([]byte, length)
-	}
+	},
 }
 
 // MaxLength is the maximum length of an element that can be added to the Pool.

diff --git a/mpool/pool_test.go b/mpool/pool_test.go
@@ -162,7 +162,7 @@ func TestPoolStressByteSlicePool(t *testing.T) {
 	if testing.Short() {
 		N /= 100
 	}
-	p := &ByteSlicePool
+	p := ByteSlicePool
 	done := make(chan bool)
 	errs := make(chan error)
 	for i := 0; i < P; i++ {