Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eventbus: log error on slow consumers #3031

Merged
merged 3 commits into from
Nov 13, 2024

Commits on Nov 7, 2024

  1. feat: eventbus: log error on slow consumers

    Slow consumers can stall libp2p in hard to debug ways. For example, a
    slow consumer of Identify events can prevent NewStreams from opening. In
    some cases we do want this back-pressure, but in other cases it is a bug
    in the user's application (or even in go-libp2p). The recommended
    approach has been to use metrics with Grafana and Prometheus to identify
    these issues. In practice, that's been a non-trivial task for users to
    setup. A simple log would help identify these issues.
    
    Note that the codepath is relatively unchanged in the normal case. Only
    if a producer is stalled will the extra work be put in.
    
    Co-authored-by: Wondertan <[email protected]>
    MarcoPolo and Wondertan committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    82de9e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    270ea36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d96e4e View commit details
    Browse the repository at this point in the history