-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move libp2p/go-libp2p-gostream to p2p/net/gostream #2535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't meant to be used directly, only as implementations of net.Listener, net.Conn and net.Addr. Accessible via Dial() and Listen().
gx publish 0.0.10
Reset streams when no reading is going to be done anymore
migrate to consolidated types.
Pass context to dial and do not hardcode it
feat: use go-libp2p-core 0.7.0 stream interfaces
fix staticcheck
Otherwise, we might close the underlying connection before it returns, causing the stream to be _reset_.
sync: update CI config files
Update libp2p
* feat: expose some read-only methods on the underlying network.Stream interface * refactor: override network.Stream instead of calling its methods individually Co-authored-by: Jacob Heun <[email protected]>
MarcoPolo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.