Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: fix Unwrap for DialError, implement Unwrap for TransportError #2437

Merged
merged 1 commit into from
Aug 25, 2023
Merged

swarm: fix Unwrap for DialError, implement Unwrap for TransportError #2437

merged 1 commit into from
Aug 25, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jul 19, 2023 •
edited
Loading

fixes: #2436

Depends on #2460 #2461
Blocked on go1.21 release.

@sukunrt sukunrt force-pushed the sukun/dial-error branch from c4eddd4 to 2342667 Compare July 19, 2023 15:00
@sukunrt sukunrt requested a review from marten-seemann July 19, 2023 15:01
@sukunrt sukunrt marked this pull request as draft July 19, 2023 15:07
@sukunrt sukunrt force-pushed the sukun/dial-error branch 2 times, most recently from 4dbd9ce to 4d5b0c9 Compare July 19, 2023 16:15
marten-seemann
marten-seemann requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a change in Go 1.20 that allows wrapping multiple errors. Should we use that new API?

We could simply wait until we drop Go 1.19 in a month, then we don't need to deal with any build flags now.

@sukunrt
Copy link
Member Author

sukunrt commented Jul 19, 2023

I don't mind waiting. This is not blocking anything.

@marten-seemann
Copy link
Contributor

We can still get it into the next release. v0.30 won't happen before the Go 1.21 transition (quic-go forces us to do so, if we want to include v0.37).

@sukunrt sukunrt mentioned this pull request Aug 7, 2023
Merged
@sukunrt sukunrt added the status/blocked Unable to be worked further until needs are met label Aug 7, 2023
@sukunrt sukunrt marked this pull request as ready for review August 7, 2023 12:01
@sukunrt sukunrt mentioned this pull request Aug 7, 2023
Closed
@sukunrt sukunrt removed the status/blocked Unable to be worked further until needs are met label Aug 14, 2023
@marten-seemann
Copy link
Contributor

#2460 and #2461. @sukunrt can you rebase please?

@marten-seemann marten-seemann mentioned this pull request Aug 25, 2023
Closed
@marten-seemann marten-seemann merged commit 57dd3bc into master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

swarm.DialError should wrap DialError.DialErrors
2 participants
@sukunrt @marten-seemann