Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport integration tests: Make TestMoreStreamsThanOurLimits less flaky #2410

Merged
merged 2 commits into from
Jul 10, 2023
Merged

transport integration tests: Make TestMoreStreamsThanOurLimits less flaky #2410

merged 2 commits into from
Jul 10, 2023

Conversation

MarcoPolo
Copy link
Collaborator

@MarcoPolo MarcoPolo commented Jul 6, 2023 •
edited
Loading

... by

  1. Counting on the initiator side (less racy and we are already waiting on a waitgroup).
  2. Slowly ramping up concurrency while we haven't seen an error, but if we see an error we'll stop increasing concurrency. Ideally the transport would block us on this but that's not how this currently works.

The goal of this test is to make sure that if a client tries deal with many streams in a reasonable way, the transport won't blow up.

Closes #2384

@MarcoPolo MarcoPolo force-pushed the marco/less-flaky-test-more-streams-than-limits branch from d282e9a to d9aaecb Compare July 6, 2023 00:12
@marten-seemann marten-seemann merged commit 732953d into master Jul 10, 2023
@MarcoPolo MarcoPolo mentioned this pull request Jul 14, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transport tests: flaky TestMoreStreamsThanOurLimits test
2 participants
@MarcoPolo @marten-seemann