chore: add 0.28.0 changelog #2335
Conversation
|
Let's discuss what we do with the Changelog going forward in 2023-06-06 maintainers call |
| @@ -9,17 +9,53 @@ | |||
| - [v0.25.1](#v0251) | |||
| - [v0.25.0](#v0250) | |||
|
|
|||
| # [v0.28.0]() | |||
| # [v0.28.0](https://github.com/libp2p/go-libp2p/releases/tag/v0.28.0) | |||
|
|
|||
| ## 🔦 Highlights <!-- omit in toc --> | |||
|
|
|||
| ### Smart Dialing <!-- omit in toc --> | |||
| * When connecting to a peer we now do [happy eyeballs](https://www.rfc-editor.org/rfc/rfc8305) like dial prioritisation to prefer QUIC addresses over TCP addresses. We dial the QUIC address first and wait 250ms to dial the TCP address of the peer. | |||
There was a problem hiding this comment.
Happy Eyeballs is specifically for IPv6 vs. IPv4, but we explicitly don't do that yet. We only delay TCP dials.
| @@ -9,17 +9,53 @@ | |||
| - [v0.25.1](#v0251) | |||
| - [v0.25.0](#v0250) | |||
|
|
|||
| # [v0.28.0]() | |||
| # [v0.28.0](https://github.com/libp2p/go-libp2p/releases/tag/v0.28.0) | |||
|
|
|||
| ## 🔦 Highlights <!-- omit in toc --> | |||
|
|
|||
| ### Smart Dialing <!-- omit in toc --> | |||
| * When connecting to a peer we now do [happy eyeballs](https://www.rfc-editor.org/rfc/rfc8305) like dial prioritisation to prefer QUIC addresses over TCP addresses. We dial the QUIC address first and wait 250ms to dial the TCP address of the peer. | |||
| * In our experiments we've seen little impact on latencies up to 80th percentile. 90th and 95th percentile latencies are impacted. For details see discussion on the [PR](https://github.com/libp2p/go-libp2p/pull/2260#issuecomment-1528848170). | |||
There was a problem hiding this comment.
That doesn't sound very promising. Should we just point to the swarm dashboards, and mention that they've been updated to show smart dialing metrics?
There was a problem hiding this comment.
I think that's a better idea. I wanted to be on the safer side when I wrote this but I'm convinced we are only impacting 95th and higher percentile latencies in most cases.
There was a problem hiding this comment.
@sukunrt please feel free to push changes directly to this branch addressing this and #2335 (comment)
| * [#2251](https://github.com/libp2p/go-libp2p/pull/2251): Infer public WebTransport address from `quic-v1` addresses if both transports are using the same port for both quic-v1 and WebTransport addresses. | ||
| * [#2271](https://github.com/libp2p/go-libp2p/pull/2271): Only add certificate hashes to WebTransport mulitaddress if listening on WebTransport |
There was a problem hiding this comment.
Can we describe why we did this?
Verdict: we'll keep the Changelog in Git, as a part of feature or bugfix PRs, we will update the corresponding release issue’s description with a blurb summarizing the change. When cutting the release, we will copy the changes in the release issue body to the the Changelog file |
|
Merging this PR so we can make progress on the notes and avoid merge conflicts. This process is painful. I'm glad we decided to revert back to a process that works. |
No description provided.