webtransport: only add cert hashes if we already started listening #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
webtransport-add-cert-hash-dont-wait
branch
from
af96e15 to
4151cd5
Compare
5 tasks
aschmahmann
reviewed
May 5, 2023
MarcoPolo
approved these changes
May 5, 2023
|
CI is not happy though |
|
go-libp2p maintainers: are we going to add a unit tests here? |
aschmahmann
reviewed
May 5, 2023
MarcoPolo
force-pushed
the
webtransport-add-cert-hash-dont-wait
branch
from
6cc7235 to
2a0242a
Compare
MarcoPolo
pushed a commit
that referenced
this pull request
May 5, 2023
MarcoPolo
pushed a commit
that referenced
this pull request
May 5, 2023
MarcoPolo
added a commit
that referenced
this pull request
May 5, 2023
* quic: fix race condition when generating random holepunch packet (#2263) * webtransport: only add cert hashes if we already started listening (#2271) * Release version v0.27.2 --------- Co-authored-by: Marten Seemann <[email protected]>
|
When running automated integration tests inside containers, is there a way to lower the udp buffer size @marten-seemann ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.