Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: fix race condition when generating random holepunch packet #2263

Merged
merged 1 commit into from
Apr 27, 2023
Merged

quic: fix race condition when generating random holepunch packet #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions p2p/transport/quic/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ type transport struct {

holePunchingMx sync.Mutex
holePunching map[holePunchKey]*activeHolePunch
rnd rand.Rand

rndMx sync.Mutex
rnd rand.Rand

connMx sync.Mutex
conns map[quic.Connection]*conn
Expand Down Expand Up @@ -218,7 +220,10 @@ func (t *transport) holePunch(ctx context.Context, raddr ma.Multiaddr, p peer.ID
var punchErr error
loop:
for i := 0; ; i++ {
if _, err := t.rnd.Read(payload); err != nil {
t.rndMx.Lock()
_, err := t.rnd.Read(payload)
t.rndMx.Unlock()
if err != nil {
punchErr = err
break
}
Expand Down