autorelay: Split libp2p.EnableAutoRelay into 2 functions #2022
Conversation
Provide two specific ways to enable the autorelay subsystem libp2p.EnableAutoRelayWithStaticRelays libp2p.EnableAutoRelayWithPeerSource
p-shahi
changed the title
|
|
||
| // WithMinInterval sets the minimum interval after which peerSource callback will be called for more | ||
| // candidates even if AutoRelay needs new candidates | ||
| func WithMinInterval(interval time.Duration) Option { |
There was a problem hiding this comment.
Why is the minimum interval both a parameter to WithPeerSource and a separate option here?
There was a problem hiding this comment.
I want to fix that, just wanted to confirm once if it's fine to change WithPeerSource method signature.
There was a problem hiding this comment.
fixed. Removed from WithPeerSource
sukunrt
force-pushed
the
split-enableautorelay
branch
from
5ad1707
to
11d8901
Compare
sukunrt
requested review from
marten-seemann
and removed request for
MarcoPolo
|
@marten-seemann addressed review comments. |
There was a problem hiding this comment.
LGTM. @MarcoPolo, could you have a look at this PR please? Just want to make sure we definitely get the API right this time.
|
Pushed a change to make the |
Co-authored-by: Marten Seemann <[email protected]>
Provide two specific ways to enable the autorelay subsystem libp2p.EnableAutoRelayWithStaticRelays
libp2p.EnableAutoRelayWithPeerSource
fixes: #1866