swarm: return filtered addrs in addrsForDial #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
changed the title
marten-seemann
approved these changes
Nov 5, 2022
There was a problem hiding this comment.
LGTM, but I'll let @MarcoPolo do another review, as this was introduced in #1719.
marten-seemann
changed the title
|
We should probably also have a test, stuff like this should have been caught be a unit test. |
|
I think this could be a candidate to include in |
MarcoPolo
approved these changes
Nov 8, 2022
MarcoPolo
pushed a commit
that referenced
this pull request
Nov 8, 2022
MarcoPolo
pushed a commit
that referenced
this pull request
Nov 9, 2022
MarcoPolo
added a commit
that referenced
this pull request
Nov 9, 2022
* fix: return filtered addrs (#1855) * Bump version * Fix concurrent map access in connmgr (#1860) * Add some guard rails and docs (#1863) Co-authored-by: Dennis Trautwein <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
f654b4bintroduced multiaddress resultion by transport and changed the return value fromgoodAddrstoresolved. I guess this should begoodAddrsagain?cc @MarcoPolo