Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default listen addresses for QUIC #1615

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Jun 24, 2022

Fixes #1671.

@marten-seemann
Copy link
Contributor Author

marten-seemann commented Jun 24, 2022

Funny, this PR is driving autorelay crazy. One more thing blocked on the refactor (#1587).

Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but we may want to hold off merging until autorelay changes are in if this causes that to be even flakier

@marten-seemann
Copy link
Contributor Author

Fixed the flaky test by only enabling the TCP transport in tests. This is not very nice, but I don't any way to prevent us from establishing multiple connections.

@marten-seemann marten-seemann merged commit 8df365b into master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rcmgr: flaky TestResourceManagerConnInbound
2 participants