move go-libp2p-pnet here #1465
Merged
move go-libp2p-pnet here #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more docs, switch errors to ipnet.NewError
io.ReadFull is garantueed to read the complete length of the buffer (or to return an error if that fails). This way, reading the nonce also succeeds when multiple Read calls are necessary.
read nonces, even if they are fragmented
use the global one
update msgio
* pull through libp2p-transport update * update moved go-libp2p-dummy-conn
gx: update deps
Read can read data *and* return an error.
annotate the "malformed key" error from pnet protector
We now "protect" below the transport layer. Also, make the tests work without the dummy conn package (one fewer deps).
wrap net conns, not transport conns
We can xor in-place (this is what secio does).
It has a nicer interface and we don't even need the rest of the msgio stuff.
switch to go-buffer-pool
It's unmaintained and pulls in github.com/whyrusleeping/cbor. This patch explicitly re-implements the minimally needed features. Also fixes #12.
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
remove dependency on go-multicodec
remove key serialization, construct conn from ipnet.PSK
fix staticcheck
marten-seemann
force-pushed
the
merge-pnet
branch
from
d738c7e
to
6f87598
Compare
Stebalien
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.