move go-conn-security-multistream here #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to wait until we're done writing before returning. The close should interrupt this process but we should still wait. might be related to ipfs/kubo#6197
block while writing
chore(dep): update
* implement simultaneous open Co-authored-by: aarshkshah1992 <[email protected]>
fix go vet and staticcheck
* use the new SecureTransport and SecureMuxer interfaces * restore sanity check for the remote peer's ID, add log statement
…/conn-security-multistream
Stebalien
approved these changes
Apr 26, 2022
| @@ -3,13 +3,13 @@ package config | |||
| import ( | |||
| "fmt" | |||
|
|
|||
| csms "github.com/libp2p/go-libp2p/p2p/net/conn-security-multistream" | |||
There was a problem hiding this comment.
Feel free to rename to something sane.
There was a problem hiding this comment.
Maybe even have a multistream package? Or an upgraders package? Not sure.
There was a problem hiding this comment.
We already have an upgrader. Can't think of something sensible for this package right now. Let's rename this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.