move go-reuseport-transport here #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason a consumer of this package would use this error as *we* retry internally. Exporting it will just confuse users.
indirectly addresses: libp2p/go-reuseport-transport#1 (comment)
No longer implicitly provided by go-reuseport's Dialer as it was removed.
Update to go-reuseport 0.2.0
We should do this from go-tcp-transport (libp2p/go-tcp-transport#36), not here, as setting linger to 0 will cause us to send RST packets instead of nicely closing connections. Also, document why we need the fallback dialer.
don't set linger to 0
Use OS routing table as a hint when dialing
Changes to go.mod has been left out: requires [email protected] and go-reuseport@master for Plan 9 support.
stop using the deprecated go-multiaddr-net package
sync: update CI config files
chore: update go-log to v2
Stebalien
approved these changes
Apr 26, 2022
p2p/net/reuseport/transport.go
Outdated
| @@ -0,0 +1,25 @@ | |||
| package tcpreuse | |||
There was a problem hiding this comment.
I would rename this to reuseport, for consistency.
marten-seemann
changed the title
Stebalien
approved these changes
May 3, 2022
marten-seemann
force-pushed
the
merge-reuseport
branch
from
8aa4fd4
to
7a9f9ad
Compare
marten-seemann
force-pushed
the
merge-reuseport
branch
from
7a9f9ad
to
6f85f7d
Compare
|
The plan is to get libp2p/go-reuseport-transport#42 merged first, then transfer the commits once again. This should allow us importing new flakiness into this repo, even temporarily. |
marten-seemann
force-pushed
the
merge-reuseport
branch
from
6f85f7d
to
492ee92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.